test: add multi gateway case #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashing <[email protected]>
Signed-off-by: ashing <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds test cases and supporting code for testing multi-gateway scenarios. Key changes include:
- Introducing support for multiple Gateway groups in the test scaffold.
- Updating dataplane tunnel creation to be reusable across additional gateway groups.
- Adding new e2e tests for multi-gateway HTTPRoute functionality.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scaffold/scaffold.go | Added data structures and helper functions for multiple gateways. |
| test/e2e/scaffold/dp.go | Refactored dataplane tunnel creation to utilize the common helper. |
| test/e2e/gatewayapi/httproute.go | Added multi-gateway HTTPRoute test case and resource creation steps. |
| internal/controller/config/config.go | Removed an unused function. |
| config/samples/config.yaml | Removed commented-out configuration for a cleaner sample. |
Signed-off-by: ashing <[email protected]>
ronething
commented
Apr 18, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for multiple gateway groups by extending the test scaffold and adding a multi-gateway test case for HTTPRoutes. It also refactors dataplane tunnel creation, renames several misnamed variables in HTTPRoute tests, and removes unused or commented-out code from configuration files.
- Added additionalGatewayGroups support and cleanup in the scaffold.
- Refactored dataplane tunnel creation to use a common helper.
- Extended HTTPRoute tests to verify multi-gateway behavior and cleaned up variable names.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/e2e/scaffold/scaffold.go | Added additional gateway groups support and cleanup logic |
| test/e2e/scaffold/dp.go | Refactored tunnel creation using createDataplaneTunnels |
| test/e2e/gatewayapi/httproute.go | Updated test cases for multi-gateway and fixed variable names |
| internal/controller/config/config.go | Removed unused validation function |
| config/samples/config.yaml | Removed commented-out configuration samples |
AlinsRan
reviewed
Apr 18, 2025
Signed-off-by: ashing <[email protected]>
AlinsRan
approved these changes
Apr 18, 2025
Signed-off-by: ashing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ashing [email protected]